Aggregator Routing Option #5349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gambol99
commented
Jun 19, 2018
gambol99
commented
- adding the enable-aggregator-routing option to the kube-apiserver
k8s-ci-robot
added
cncf-cla: yes
|
in reference to #5345 |
|
/assign @KashifSaadat |
KashifSaadat
suggested changes
Jun 19, 2018
pkg/apis/kops/componentconfig.go
Outdated
| @@ -220,6 +220,8 @@ type KubeAPIServerConfig struct { | |||
| InsecureBindAddress string `json:"insecureBindAddress,omitempty" flag:"insecure-bind-address"` | |||
| // EnableBootstrapAuthToken enables 'bootstrap.kubernetes.io/token' in the 'kube-system' namespace to be used for TLS bootstrapping authentication | |||
| EnableBootstrapAuthToken *bool `json:"enableBootstrapTokenAuth,omitempty" flag:"enable-bootstrap-token-auth"` | |||
| // EnableAggregatorRouting enables aggregator routing requests to endoints IP rather than cluster IP | |||
There was a problem hiding this comment.
endoints => endpoints
|
One small typo in the comment, otherwise LGTM |
- adding the enable-aggregator-routing option to the kube-apiserver
|
fixed the typo upstream in the kubernetes repo and here .. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, KashifSaadat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 23, 2018
- nothing much here just a typo fix found when copied and pasting into a kops PR kubernetes/kops#5349
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Aug 23, 2018
Automatic merge from submit-queue (batch tested with PRs 65247, 63633, 67425). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Typo Fix - nothing much here just a typo fix found when copying and pasting into a kops [#PR5349](kubernetes/kops#5349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.