Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployment timeout reporting #52178

Merged
merged 1 commit into from
Sep 16, 2017
Merged

Fix deployment timeout reporting #52178

merged 1 commit into from
Sep 16, 2017
+25 −4

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Sep 8, 2017 •
edited
Loading

If the previous condition has been a successful rollout then we
shouldn't try to estimate any progress. Scenario:

  • progressDeadlineSeconds is smaller than the difference between
    now and the time the last rollout finished in the past.
  • the creation of a new ReplicaSet triggers a resync of the
    Deployment prior to the cached copy of the Deployment getting
    updated with the status.condition that indicates the creation
    of the new ReplicaSet.

The Deployment will be resynced and eventually its Progressing
condition will catch up with the state of the world.

Signed-off-by: Michail Kargakis [email protected]

Cherry-pick of #52127 to 1.7

Fixes #49637

@kubernetes/sig-apps-pr-reviews

Fixed an issue reporting lack of progress for a deployment prematurely

@0xmichalis
Fix deployment timeout reporting
abf13d4 
If the previous condition has been a successful rollout then we
shouldn't try to estimate any progress. Scenario:

* progressDeadlineSeconds is smaller than the difference between
  now and the time the last rollout finished in the past.
* the creation of a new ReplicaSet triggers a resync of the
  Deployment prior to the cached copy of the Deployment getting
  updated with the status.condition that indicates the creation
   of the new ReplicaSet.

The Deployment will be resynced and eventually its Progressing
condition will catch up with the state of the world.

Signed-off-by: Michail Kargakis <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2017
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2017
@0xmichalis 0xmichalis added this to the v1.7 milestone Sep 8, 2017
@0xmichalis
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 8, 2017
@0xmichalis
Copy link
Contributor Author

/retest

@0xmichalis
Copy link
Contributor Author

/approve 49637

@0xmichalis
Copy link
Contributor Author

/approve #49637

@0xmichalis
Copy link
Contributor Author

/approve no-issue

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2017
@0xmichalis 0xmichalis mentioned this pull request Sep 11, 2017
Closed
@mfojtik
Copy link
Contributor

mfojtik commented Sep 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2017
@0xmichalis
Copy link
Contributor Author

/approve cancel

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kargakis, mfojtik

Associated issue: 49637

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor Author

@wojtek-t ptal

@wojtek-t wojtek-t added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed release-note-none Denotes a PR that doesn't merit a release note. cherrypick-candidate do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Sep 15, 2017
@0xmichalis
Copy link
Contributor Author

/retest

@wojtek-t
Copy link
Member

/retest

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Sep 15, 2017 •
edited
Loading

The gce job failure is an infra problem:

W0915 09:59:45.226] 2017/09/15 09:59:45 main.go:270: Something went wrong: failed to prepare test environment: --provider=gce boskos failed to acquire project: Post http://boskos/acquire?type=gce-project&state=free&dest=busy&owner=pull-kubernetes-e2e-gce-bazel: dial tcp 10.63.250.132:80: i/o timeout

@wojtek-t
Copy link
Member

/retest

@mattfarina
Copy link
Contributor

Looking at the bazel test failure I see boskos failed to acquire project. Boskos might be having some issues right now. Could be that instead of the test itself.

@0xmichalis
Copy link
Contributor Author

@mattfarina yeah, since yesterday there have been some issues with gce projects ... @krzyzacy is looking at it.

@krzyzacy
Copy link
Member

yeah kubernetes/test-infra#4571

(Why I don't see the required context anymore)

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 4081149 into kubernetes:release-1.7 Sep 16, 2017
@k8s-ci-robot
Copy link
Contributor

@Kargakis: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce abf13d4 link /test pull-kubernetes-federation-e2e-gce
pull-kubernetes-e2e-gce-bazel abf13d4 link /test pull-kubernetes-e2e-gce-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@0xmichalis 0xmichalis deleted the cherry-pick-to-17 branch September 16, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@mfojtik mfojtik

@janetkuo janetkuo

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
9 participants
@0xmichalis @mfojtik @k8s-github-robot @wojtek-t @mattfarina @krzyzacy @fejta-bot @k8s-ci-robot @janetkuo