Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

approval with issue didn't work #4512

Closed
0xmichalis opened this issue Sep 11, 2017 · 3 comments
Closed

approval with issue didn't work #4512

0xmichalis opened this issue Sep 11, 2017 · 3 comments
Assignees
@apelisse @cjwagner

Comments

@0xmichalis
Copy link
Contributor

kubernetes/kubernetes#52178 (comment)

/area mungegithub
/assign @apelisse @cjwagner
@cjwagner
Copy link
Member

The issue should be specified in the body, see here for how the issue is found.

@0xmichalis
Copy link
Contributor Author

What does the "body" mean? Is it the body of the initial comment? Is this documented somewhere? I was surprised that /approve #NO wasn't working.

@cjwagner
Copy link
Member

The main PR description body. This is documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apelisse apelisse

@cjwagner cjwagner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apelisse @0xmichalis @cjwagner @k8s-ci-robot