Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Rename storage class labels reclaimPolicy to reclaim_policy and volumeBindingMode to volume_binding_mode #996

Closed
wants to merge 1 commit into from
Closed

v2: Rename storage class labels reclaimPolicy to reclaim_policy and volumeBindingMode to volume_binding_mode #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/store/storageclass.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var (
}

m := metric.Metric{
LabelKeys: []string{"provisioner", "reclaimPolicy", "volumeBindingMode"},
LabelKeys: []string{"provisioner", "reclaim_policy", "volume_binding_mode"},
LabelValues: []string{s.Provisioner, string(*s.ReclaimPolicy), string(*s.VolumeBindingMode)},
Value: 1,
}
Expand Down
4 changes: 2 additions & 2 deletions internal/store/storageclass_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func TestStorageClassStore(t *testing.T) {
Want: `
# HELP kube_storageclass_info Information about storageclass.
# TYPE kube_storageclass_info gauge
kube_storageclass_info{storageclass="test_storageclass-info",provisioner="kubernetes.io/rbd",reclaimPolicy="Delete",volumeBindingMode="Immediate"} 1
kube_storageclass_info{storageclass="test_storageclass-info",provisioner="kubernetes.io/rbd",reclaim_policy="Delete",volume_binding_mode="Immediate"} 1
`,
MetricNames: []string{
"kube_storageclass_info",
Expand All @@ -60,7 +60,7 @@ func TestStorageClassStore(t *testing.T) {
Want: `
# HELP kube_storageclass_info Information about storageclass.
# TYPE kube_storageclass_info gauge
kube_storageclass_info{storageclass="test_storageclass-default-info",provisioner="kubernetes.io/rbd",reclaimPolicy="Delete",volumeBindingMode="Immediate"} 1
kube_storageclass_info{storageclass="test_storageclass-default-info",provisioner="kubernetes.io/rbd",reclaim_policy="Delete",volume_binding_mode="Immediate"} 1
`,
MetricNames: []string{
"kube_storageclass_info",
Expand Down