Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: Rename storage class labels reclaimPolicy to reclaim_policy and volumeBindingMode to volume_binding_mode #996

Closed
wants to merge 1 commit into from

Conversation

Dingshujie
Copy link
Member

What this PR does / why we need it:
Rename storage class labels reclaimPolicy to reclaim_policy and volumeBindingMode to volume_binding_mode
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #981

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dingshujie
To complete the pull request process, please assign lilic
You can assign the PR to them by writing /assign @lilic in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Member

lilic commented Dec 11, 2019

/hold

until the release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, this looks good, lets just wait until after the release to merge.

@tariq1890 tariq1890 added the v2 version 2 label Dec 17, 2019
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit odd that CI did not catch this, but do you mind updating the docs for this as well, thanks!

https://github.com/kubernetes/kube-state-metrics/blob/master/docs/storageclass-metrics.md

@lilic
Copy link
Member

lilic commented Mar 20, 2020

@Dingshujie friendly ping :) thanks!

@olivierlemasle
Copy link
Member

olivierlemasle commented Mar 27, 2020

/close
Done with #1107

@k8s-ci-robot
Copy link
Contributor

@olivierlemasle: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v2 version 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: Rename storage class labels reclaimPolicy to reclaim_policy and volumeBindingMode to volume_binding_mode
5 participants