-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use string verb to format logging messages in tests #2363
Conversation
The %w makes the CI to fail, replacing it back to %s
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This verb can be used only in 'fmt.Errorf' calls (%w) which makes the CI to fail on the main branch, see ci-go-lint, ci-benchmark-tests, ci-e2e-tests. /assign @rexagod |
The |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, ovidiutirla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merging this manually to get CI working :) |
That's my bad, I didn't notice the |
What this PR does / why we need it:
The %w makes the CI to fail, replacing it back to %s.
After the #2358 was merged, looks like the CI is failing on the main branch.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
no impact
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #