Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorganize documentation directory structure #2358

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

ovidiutirla
Copy link
Contributor

What this PR does / why we need it:
Fixes #1903

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
no impact

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes ##1903

Testing

$ make doccheck 
GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -ldflags "-s -w -X github.com/prometheus/common/version.Version=v2.11.0 -X github.com/prometheus/common/version.Revision=fc204cb8 -X github.com/prometheus/common/version.Branch=reorg-docs -X github.com/prometheus/common/[email protected] -X github.com/prometheus/common/version.BuildDate=2024-04-03T10:30:58Z" -o kube-state-metrics
gomplate -d config=./data.yaml --file README.md.tpl > README.md
>> generating docs
embedmd -w `find . -path ./vendor -prune -o -name "*.md" -print`
git diff --no-ext-diff --quiet --exit-code README.md
- Checking if the generated documentation is up to date...
- Checking if the documentation is in sync with the code...
OK
- Checking for orphan documentation files
OK

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ovidiutirla!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 3, 2024
@ovidiutirla ovidiutirla changed the title Reorganize documentation directory structure docs: reorganize documentation directory structure Apr 3, 2024
@ovidiutirla
Copy link
Contributor Author

adding @dgrisonnet. Happy to address any additional feedback.

@CatherineF-dev
Copy link
Contributor

overall lgtm. Added few comments.

@ovidiutirla
Copy link
Contributor Author

hey @rexagod, I'm happy to address any other feedback. Thank you.

tests/e2e/main_test.go Outdated Show resolved Hide resolved
@dgrisonnet
Copy link
Member

/assign @rexagod

@dgrisonnet
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2024
Co-authored-by: Pranshu Srivastava <[email protected]>
@rexagod
Copy link
Member

rexagod commented Apr 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ovidiutirla, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit ea8a7f8 into kubernetes:main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup documentation directory structure
5 participants