-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration test to cover CloudFormation output of NAT gateways #8053
Update integration test to cover CloudFormation output of NAT gateways #8053
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8b7ecb4
to
da3bbfd
Compare
da3bbfd
to
bb3140d
Compare
@@ -0,0 +1,490 @@ | |||
Resources.AWSAutoScalingLaunchConfigurationmasterustest1amastersprivatecalicoexamplecom.Properties.UserData: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rifelpet just for my own understanding, is this copied from elsewhere or generated somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is generated. I think some of our tests have an env var you can set that will write the actual output to the expected files so you can make updates like this easily, but I don’t think these integration tests support that. I ended up just making these files empty, ran the tests, then copied the diff outputted by the failing test into the files.
/lgtm |
I noticed that #8051 didnt require updating an tests in order to pass which means that cloudformation output of NAT gateways weren't covered by our integration tests.
This adds that to the complex test case. this should cause #8051 to fail until it updates the expected CF as well :)