Fix CloudFormation template tags for NatGateway

[hakman]

CloudFormation template that is generated by Kops has the tags in the AWS::EC2::NatGateway incorrectly formatted and fails to install, as described in #7452 .

I cannot confirm that the Tags section is unsupported anymore for AWS::EC2::EIP. For me works without any problem.

Fixes #7452

[k8s-ci-robot]

Hi @hakman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rifelpet]

/ok-to-test

[hakman]

/assign @gambol99

[rifelpet]

Nice work!

I noticed this wasn't under any test coverage so I opened #8053 to add that. Once that is merged we should rebase this PR and update the expected cloudformation output to match the fixed tag format.

[hakman]

Thanks @rifelpet. Good idea.
Btw, I noticed that it's pretty easy to hit the 51200 bytes limit on the template now. Maybe would be a good idea to put the template in the S3 bucket also and recommend people to use --template-url instead of --template-body, as that limit is 10x times bigger.

For reference: kubernetes-retired/kube-aws#38

[rifelpet]

If there isn't an issue open already regarding the size limit, perhaps you could open one? It sounds reasonable to me.

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

Thanks @rifelpet. All issues on the topic were closed due to inactivity, so opened a new one with a few proposals. #8065