Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated container-selinux url to point to the right path #7609

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Updated container-selinux url to point to the right path #7609

merged 2 commits into from
Sep 18, 2019

Conversation

igarcia-sugarcrm
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @igarcia-sugarcrm!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @igarcia-sugarcrm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 17, 2019
@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2019
rifelpet
rifelpet requested changes Sep 18, 2019
View reviewed changes
nodeup/pkg/model/docker.go Outdated
@@ -557,7 +557,7 @@ var dockerVersions = []dockerVersion{
ExtraPackages: map[string]packageInfo{
"container-selinux": {
Version: "2.68",
Source: "http://mirror.centos.org/centos/7/extras/x86_64/Packages/container-selinux-2.68-1.el7.noarch.rpm",
Source: "http://mirror.centos.org/centos/7.6.1810/extras/x86_64/Packages/container-selinux-2.68-1.el7.noarch.rpm",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your editor may have replaced the tabs with spaces. Can you update your commit to use tabs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix, so this should be resolved shortly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry about that.

@mikesplain
Copy link
Contributor

I believe this is the better fix for this issue since it leaves versions of packages the same, which are certified per K8s version.

@mikesplain mikesplain mentioned this pull request Sep 18, 2019
Closed
@mikesplain
Copy link
Contributor

/assign

@mikesplain
Copy link
Contributor

/retest

@gjtempleton gjtempleton mentioned this pull request Sep 18, 2019
Closed
@mikesplain
Copy link
Contributor

Tested and confirmed this fixes the issue at hand. Thanks for the fix everyone! We'll get cherry-picks open asap.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igarcia-sugarcrm, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0ae4613 into kubernetes:master Sep 18, 2019
@igarcia-sugarcrm igarcia-sugarcrm deleted the issue/7608 branch September 18, 2019 17:25
This was referenced Sep 18, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 18, 2019
@k8s-ci-robot
Merge pull request #7627 from mikesplain/automated-cherry-pick-of-#76…
a9ba496 
…09-origin-release-1.14

Automated cherry pick of #7609: Updated container-selinux url to pint to the right path
k8s-ci-robot added a commit that referenced this pull request Sep 18, 2019
@k8s-ci-robot
Merge pull request #7628 from mikesplain/automated-cherry-pick-of-#76…
bb531e9 
…09-origin-release-1.15

Automated cherry pick of #7609: Updated container-selinux url to pint to the right path
k8s-ci-robot added a commit that referenced this pull request Sep 18, 2019
@k8s-ci-robot
Merge pull request #7626 from mikesplain/automated-cherry-pick-of-#76…
3c8cb3e 
…09-origin-release-1.13

Automated cherry pick of #7609: Updated container-selinux url to pint to the right path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain left review comments

@rifelpet rifelpet rifelpet requested changes

@robinpercy robinpercy Awaiting requested review from robinpercy

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igarcia-sugarcrm @k8s-ci-robot @rifelpet @mikesplain