Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verify bazel and expose error #6841

Merged

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Apr 26, 2019

We already run this in prow so no need it in two places.

I'll open a separate PR to fix the lack of output from the verify bazel test failure.

Easy enough fix, including here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@mikesplain mikesplain changed the title Remove verify bazel from travis its run in prow Remove verify bazel and expose error Apr 26, 2019
@mikesplain
Copy link
Contributor Author

/assign @rdrgmnzs
/assign @granular-ryanbonham

@mikesplain
Copy link
Contributor Author

Watching for failed output in #6844 to test. Currently our error messages were getting hidden, hopefully this should fix it in prow

@mikesplain
Copy link
Contributor Author

@granular-ryanbonham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8b72574 into kubernetes:master Apr 26, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
…41-origin-release-1.13

Automated cherry pick of #6841: Remove verify bazel from travis its run in prow
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2019
…41-origin-release-1.14

Automated cherry pick of #6841: Remove verify bazel from travis its run in prow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants