Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit Tests] Add unit tests for create_kubecfg file #6826

Merged
merged 4 commits into from
Apr 28, 2019

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Apr 25, 2019

Hi - Please find the first pull request for KOPS.
I added a new unit test file for testing building kube config file for different scenarios - A public DNS cluster, gossip cluster, a cluster with no master public name etc.

Please have a look and let me know if you have any questions.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2019
@srikiz
Copy link
Contributor Author

srikiz commented Apr 25, 2019

/retest

@k8s-ci-robot
Copy link
Contributor

@srikiz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@srikiz
Copy link
Contributor Author

srikiz commented Apr 25, 2019

/help Not sure why the Travis CI is failing. Can anyone help?

@mikesplain
Copy link
Contributor

Hi @srikiz, since you made a change you'll need to run make bazel-gazelle to regenerate bazel's buildfiles. Let me know if you need help with that!

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2019
@kubernetes kubernetes deleted a comment from k8s-ci-robot Apr 26, 2019
@mikesplain
Copy link
Contributor

So we need to make those outputs a bit better and I've removed this test in travis: #6841

@srikiz
Copy link
Contributor Author

srikiz commented Apr 26, 2019

Thanks @mikesplain - That went through well. It looks like the pull-kops-verify-gofmt is failing now. Can you please suggest how to go about on this issue.

@srikiz
Copy link
Contributor Author

srikiz commented Apr 26, 2019

/retest

@mikesplain
Copy link
Contributor

That should be fixed via make gofmt. Checkin the results and you should be good to go.

@srikiz
Copy link
Contributor Author

srikiz commented Apr 27, 2019

/assign @geojaz

@chrisz100
Copy link
Contributor

/lgtm
/approve

Great that you have motivation to work on the test coverage! Love that, keep it up :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6d3c67a into kubernetes:master Apr 28, 2019
@srikiz srikiz deleted the MoreUnitTests branch May 14, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants