-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unit Tests] Add unit tests for create_kubecfg file #6826
Conversation
Hi @srikiz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@srikiz: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/help Not sure why the Travis CI is failing. Can anyone help? |
Hi @srikiz, since you made a change you'll need to run |
/ok-to-test |
So we need to make those outputs a bit better and I've removed this test in travis: #6841 |
Thanks @mikesplain - That went through well. It looks like the pull-kops-verify-gofmt is failing now. Can you please suggest how to go about on this issue. |
/retest |
That should be fixed via |
/assign @geojaz |
/lgtm Great that you have motivation to work on the test coverage! Love that, keep it up :-) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, srikiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi - Please find the first pull request for KOPS.
I added a new unit test file for testing building kube config file for different scenarios - A public DNS cluster, gossip cluster, a cluster with no master public name etc.
Please have a look and let me know if you have any questions.