Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #5513 onto release-1.10 #5683

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Cherry pick of #5513 onto release-1.10 #5683

merged 1 commit into from
Dec 22, 2018

Conversation

lneves75
Copy link

Backporting #5513 into 1.10

Without this change, for example, kops connections using OIDC to the
cluster will receive this error message:

> cannot build kube client for "$CLUSTER_NAME": No Auth Provider found
> for name "oidc"

kubernetes/client-go#345 suggests importing the package path
`plugin/pkg/client/auth/oidc` from `client-go`, but looking at the code
`plugin/pkg/client/auth` will actually handle loading all known auth
plugins for us.

Without this change, for example, kops connections using OIDC to the
cluster will receive this error message:

> cannot build kube client for "$CLUSTER_NAME": No Auth Provider found
> for name "oidc"

kubernetes/client-go#345 suggests importing the package path
`plugin/pkg/client/auth/oidc` from `client-go`, but looking at the code
`plugin/pkg/client/auth` will actually handle loading all known auth
plugins for us.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2018
@lneves75
Copy link
Author

/assign @mikesplain

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2018
@chrisz100
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2018
@gwohletz
Copy link

This appears to have missed the 1.10 release, making it unusable with oidc, please include in the next release

@lneves75
Copy link
Author

/assign @mikesplain

@mikesplain
Copy link
Contributor

We're trying to push out 1.11 so I'm not sure if we're doing any patches to 1.10 at the moment. Lets hold off on merging this until we know for sure.

@eyalzek
Copy link

eyalzek commented Nov 6, 2018

Is this on the 1.11 alpha release?

@justinsb
Copy link
Member

This will be in 1.11 (you can see the branches in the original PR).

I'm wavering on whether this is a feature or a bugfix, but I'm going to merge it.

Thanks @ripta and @lneves75

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, lneves75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@justinsb justinsb mentioned this pull request Dec 21, 2018
@rdrgmnzs
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@justinsb
Copy link
Member

The first failure was a double-build of protokube (changed SHA)

@k8s-ci-robot
Copy link
Contributor

@lneves75: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 030ee77 link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member

These failures are because I didn't set up the PR test job for 1.10 correctly, but it'll get tested post-merge anyway (every 6 hours). Merging manually!

@justinsb justinsb merged commit 2e240c7 into kubernetes:release-1.10 Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants