-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick of #5513 onto release-1.10 #5683
Cherry pick of #5513 onto release-1.10 #5683
Conversation
Without this change, for example, kops connections using OIDC to the cluster will receive this error message: > cannot build kube client for "$CLUSTER_NAME": No Auth Provider found > for name "oidc" kubernetes/client-go#345 suggests importing the package path `plugin/pkg/client/auth/oidc` from `client-go`, but looking at the code `plugin/pkg/client/auth` will actually handle loading all known auth plugins for us.
/assign @mikesplain |
/ok-to-test |
/test pull-kops-e2e-kubernetes-aws |
/lgtm |
This appears to have missed the 1.10 release, making it unusable with oidc, please include in the next release |
/assign @mikesplain |
We're trying to push out 1.11 so I'm not sure if we're doing any patches to 1.10 at the moment. Lets hold off on merging this until we know for sure. |
Is this on the 1.11 alpha release? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, lneves75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kops-e2e-kubernetes-aws |
The first failure was a double-build of protokube (changed SHA) |
@lneves75: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
These failures are because I didn't set up the PR test job for 1.10 correctly, but it'll get tested post-merge anyway (every 6 hours). Merging manually! |
Backporting #5513 into 1.10