-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load client-auth plugins #5513
Load client-auth plugins #5513
Conversation
/assign kashifsaadat This is the first time I've touched |
/assign @KashifSaadat Whoops, left off the |
/ok-to-test |
Hi @ripta, in order to get this to pass you'll need to reorder your insert in BUILD.bazel. Please checkout the failed test. If you run |
Without this change, for example, kops connections using OIDC to the cluster will receive this error message: > cannot build kube client for "$CLUSTER_NAME": No Auth Provider found > for name "oidc" kubernetes/client-go#345 suggests importing the package path `plugin/pkg/client/auth/oidc` from `client-go`, but looking at the code `plugin/pkg/client/auth` will actually handle loading all known auth plugins for us.
843fdb5
to
2171360
Compare
@mikesplain - Thanks for the pointer. I amended my commit. I'll retest and check back. /retest |
/lgtm |
Thanks for the contribution @ripta :) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, KashifSaadat, ripta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…se-1.10 Cherry pick of #5513 onto release-1.10
Without this change, for example, kops connections using OIDC to the cluster will receive this error message:
kubernetes/client-go#345 suggests importing the package path
plugin/pkg/client/auth/oidc
fromclient-go
. However, looking at the code atplugin/pkg/client/auth
, it will actually handle loading all known auth plugins for us.