Apply cloud labels into ELB

[wingyplus]

Fixes #2048

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wingyplus]

/assign @chrislovecnm

[mikesplain]

/ok-to-test

[wingyplus]

/test pull-kops-e2e-kubernetes-aws

[wingyplus]

/cc @mikesplain

[KashifSaadat]

Thanks for the fix @wingyplus, looks good :)

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, wingyplus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KashifSaadat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wingyplus]

@KashifSaadat Thanks :)

[gambol99]

This is a dangerous one to add as i've just encounter. Beforehand the cloud tags were not added but now they are and expected in the 'find' of the fi tasks .. This cause's a number of resources which was not presently tagged (vpc, subnets, routing tables etc) by a previous kops binary not to be found and be marked as creating on the kops apply. Also we use dynamic tags (i.e. gitsha's and release version) which would never work ... Thankfully it was in testing .. @mikesplain @justinsb ..

[justinsb]

So this had to be reverted - if you're still interested in pursuing it, I think you need to plumb through the additional tags here:

kops/pkg/model/awsmodel/api_loadbalancer.go

Line 117 in c55b032

elb = &awstasks.LoadBalancer{

i.e. specifically in the ELB, not generally at the cloud level.

The problem is that tags at the cloud level act as a filter. Another option would be to have tags at the cloud level that are added, but don't act as a filter - that would be the spirit of what you've done in this PR.