Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudLabels for API ELB #2048

Closed
hridyeshpant opened this issue Mar 4, 2017 · 14 comments
Closed

cloudLabels for API ELB #2048

hridyeshpant opened this issue Mar 4, 2017 · 14 comments

Comments

@hridyeshpant
Copy link

It seems cloudLabels is not putting TAG on API ELB's.
kops create cluster --v=3 --state=s3://ewe-kubernetes-dev --cloud=aws
--name=kubetnets.us-west-2.dev.expedia.com
--ssh-public-key=~/.ssh/kube_aws_rsa.pub
--master-size=t2.medium
--cloud-labels="Team=CAT"
--master-zones=us-west-2c,us-west-2a,us-west-2b
--network-cidr=10.4.0.0/16
--vpc=vpc-030e8f64
--node-count=3
--node-size=t2.micro
--topology private
--networking weave
--zones=us-west-2c,us-west-2a,us-west-2b
--channel=alpha

Result : k8 API ELB's dont have AWS TAG mentioned in cloud-labels.

@richarvey
Copy link

I can confirm this is the case, labels are not applied to the ELB, so if you have a AWS janitor to clear up untagged resources this is an issue.

@estebancrw
Copy link

estebancrw commented Aug 9, 2017

I'm also having this issue. Any way to work around it at the moment or any plans into adding this use case in the future?
This can be done in k8s since v1.7.0 with annotations service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags, but I'm not sure how to do this with the ELB from kops

@geojaz
Copy link
Member

geojaz commented Oct 23, 2017

My understanding is that cloud labels are associated with InstanceGroups, not all AWS resources. In this case, I think kops is acting as intending.

It looks like you'd like to be able to assign a "global" tag to all resources in your cluster? This sounds like a reasonable thing to do and I would be open to thinking about implementation.

@chrislovecnm
Copy link
Contributor

So we already have global tags, KubernetesCluster for instance. But not sure if we should use it in the elb, as I am not certain how the cloud provider will react ;)

Let me know Eric

@estebancrw
Copy link

@geojaz That is exactly my use-case. Some organizations have created "janitors" that delete AWS resources not tagged as they specify. This "janitors" tend to be for enforcing their tagging policies so they can bill correctly their own business units and budget accordingly.

@chrislovecnm would be an awesome feature to be able to extend the CloudLabels into global tags.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2018
@brantburnett
Copy link

/remove-lifecycle stale

This is also an issue for my company, for the same reasons as mentioned above surrounding billing

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@jcardoso-bv
Copy link

Also an issue for my company (billing).

@tonidas
Copy link

tonidas commented May 14, 2018

That's really an issue!

@flamingspaz
Copy link

Has anyone found a workaround for this, other than manually applying the tags?

@lvicentesanchez
Copy link

I'm also suffering from this problem

wingyplus added a commit to wingyplus/kops that referenced this issue Aug 10, 2018
wingyplus added a commit to wingyplus/kops that referenced this issue Aug 10, 2018
wingyplus added a commit to wingyplus/kops that referenced this issue Aug 10, 2018
@wingyplus
Copy link
Contributor

I just sent a patch to fix this problem. Needs someone to help me test this patch. Suggestions are welcome. :)

wingyplus added a commit to wingyplus/kops that referenced this issue Aug 10, 2018
@chrisz100
Copy link
Contributor

/reopen

Fix seems to have gotten reverted

@k8s-ci-robot k8s-ci-robot reopened this Mar 13, 2019
@k8s-ci-robot
Copy link
Contributor

@chrisz100: Reopened this issue.

In response to this:

/reopen

Fix seems to have gotten reverted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests