-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudLabels for API ELB #2048
Comments
I can confirm this is the case, labels are not applied to the ELB, so if you have a AWS janitor to clear up untagged resources this is an issue. |
I'm also having this issue. Any way to work around it at the moment or any plans into adding this use case in the future? |
My understanding is that cloud labels are associated with InstanceGroups, not all AWS resources. In this case, I think kops is acting as intending. It looks like you'd like to be able to assign a "global" tag to all resources in your cluster? This sounds like a reasonable thing to do and I would be open to thinking about implementation. |
So we already have global tags, KubernetesCluster for instance. But not sure if we should use it in the elb, as I am not certain how the cloud provider will react ;) Let me know Eric |
@geojaz That is exactly my use-case. Some organizations have created "janitors" that delete AWS resources not tagged as they specify. This "janitors" tend to be for enforcing their tagging policies so they can bill correctly their own business units and budget accordingly. @chrislovecnm would be an awesome feature to be able to extend the CloudLabels into global tags. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale This is also an issue for my company, for the same reasons as mentioned above surrounding billing |
Also an issue for my company (billing). |
That's really an issue! |
Has anyone found a workaround for this, other than manually applying the tags? |
I'm also suffering from this problem |
I just sent a patch to fix this problem. Needs someone to help me test this patch. Suggestions are welcome. :) |
/reopen Fix seems to have gotten reverted |
@chrisz100: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It seems cloudLabels is not putting TAG on API ELB's.
kops create cluster --v=3 --state=s3://ewe-kubernetes-dev --cloud=aws
--name=kubetnets.us-west-2.dev.expedia.com
--ssh-public-key=~/.ssh/kube_aws_rsa.pub
--master-size=t2.medium
--cloud-labels="Team=CAT"
--master-zones=us-west-2c,us-west-2a,us-west-2b
--network-cidr=10.4.0.0/16
--vpc=vpc-030e8f64
--node-count=3
--node-size=t2.micro
--topology private
--networking weave
--zones=us-west-2c,us-west-2a,us-west-2b
--channel=alpha
Result : k8 API ELB's dont have AWS TAG mentioned in cloud-labels.
The text was updated successfully, but these errors were encountered: