Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: etcd volume provisioned IOPS support #4852

Merged
merged 1 commit into from
Apr 2, 2018
Merged

AWS: etcd volume provisioned IOPS support #4852

merged 1 commit into from
Apr 2, 2018

Conversation

sergeylanzman
Copy link
Contributor

@sergeylanzman sergeylanzman commented Apr 1, 2018 •
edited
Loading

Fix for #4720
same issue as #3278

PR same like #3102

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2018
@justinsb
Copy link
Member

justinsb commented Apr 2, 2018

/ok-to-test

/lgtm

Might be some more work here, but given the etcd-quorum issues & the inability to create io1 volumes otherwise, I want to allow it at least for new clusters - and this is very low risk:

  • we probably should add some validation around the iops fields (low priority)
  • we should add output support to terraform & cloudformation
  • we should add it to the Find()
  • we should make it so that we can change the provisioned iops on an existing volume

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, sergeylanzman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2018
This was referenced Apr 2, 2018
Closed
Closed
Closed
Closed
@justinsb justinsb added this to the 1.9.0 milestone Apr 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit b879393 into kubernetes:master Apr 2, 2018
@sergeylanzman
Copy link
Contributor Author

@justinsb
we should add it to the Find() => https://github.com/kubernetes/kops/pull/4852/files#diff-28f2ed90f7519537a083ae228827cb16R105 ?

@rajaneeshk1990
Copy link

Unsupported volume type 'iops' for volume creation

@mikesplain mikesplain mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sergeylanzman @justinsb @k8s-ci-robot @rajaneeshk1990