-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: root volume provisioned IOPS support #3102
Conversation
Hi @yoz2326. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @chrislovecnm |
/ok-to-test |
/lgtm |
This is great - thanks @yoz2326 |
/approve no-issue |
1 similar comment
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, yoz2326 Associated issue requirement bypassed by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
/test pull-kops-e2e-kubernetes-aws |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
It is possible to set
rootVolumeType: gp2
so an instance group will usegp2
as disk type (https://github.com/kubernetes/kops/blob/master/docs/instance_groups.md)If the option is set to
rootVolumeType: io1
then the below error is thrown when building the cluster:W0731 13:44:44.298875 8784 executor.go:109] error running task "LaunchConfiguration/master-eu-west-1a.masters.cluster.name" (9m48s remaining to succeed): error creating AutoscalingLaunchConfiguration: ValidationError: Iops is required for a provisioned IOPS volume. status code: 400, request id: 072e23b2-75ee-11e7-968a-191d6f6e9343
This PR tries to address this so if anyone needs, it can use
io1
as disk type for the root volume.In order to define the number of Iops set
rootVolumeIops: <number>
(minimum is 100)If
rootVolumeType: io1
is set androotVolumeIops
is not defined, thenrootVolumeIops
defaults to 100.I am not quite familiar with the Kops codebase and this is my first encounter with Go, so some changes might not be suitable (I also do not have a software developer background so bear with me :) ). Please review and add feed-back.
I've included a small change to the Makefile as I compiled Kops on a Mac and didn't had $GOPATH set after installing Go. I thought that pulling this via
go env
would be more flexible, but I am not 100% sure as I don't do much development in this area and not sure about possible use cases.