Remove manually added labels from addons #10987
Conversation
k8s-ci-robot
added
size/L
hakman
added
the
kind/cleanup
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Was a pleasure. Now I don't have to see them every time I update Calico. |
| namespace: kube-system | ||
| spec: | ||
| # Wait 5 seconds to let pod connect before rolling next pod | ||
| selector: | ||
| matchLabels: | ||
| name: weave-net | ||
| role.kubernetes.io/networking: "1" |
There was a problem hiding this comment.
@hakman this breaks the weave addon update as selector labels are immutable, logs from protokube
The DaemonSet "weave-net" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"name":"weave-net"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable
error updating "networking.weave": error applying update from "s3://kops...": error running kubectl: exit status 1
There was a problem hiding this comment.
Support for weave has been removed now due to the inactivity of upstream. So I while we did an unintentional breaking change here, I think the path forward is to migrate to another CNI.
There was a problem hiding this comment.
Thanks for the reply, migration from weave is planned but this added an extra twist.
This removes
role.kubernetes.io/networking: "1"androle.kubernetes.io/authentication: "1"labels which are now added automatically since #10796./cc @olemarkus