Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standardised set of labels on all resources #10796

Merged
merged 2 commits into from
Feb 28, 2021

Conversation

olemarkus
Copy link
Member

@olemarkus olemarkus commented Feb 11, 2021

This PR will use the manifest remap functionality to add a standardised set of labels to all manifests.

I think this one is useful in many ways:

  1. it ensures the addon selector is actually available on all resources and that they are set correctly (which was not the case)
  2. it makes it easy for users to see what comes from kOps and what came from elsewhere
  3. it makes it easy to see what version of an addon was installed
  4. further down the line we could implement some naïve "delete all resources that has the managed-by label and a lower addon version"
  5. we could implement addon deletion functionality into channels that users could use to remove addons (or "vendor" that into kOps CLI)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 11, 2021
@olemarkus olemarkus force-pushed the annotate-all-the-things branch from df5e59e to e26cd29 Compare February 11, 2021 20:23
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2021
@olemarkus olemarkus force-pushed the annotate-all-the-things branch from e26cd29 to bca8573 Compare February 28, 2021 06:45
@k8s-ci-robot k8s-ci-robot added area/addons and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8290268 into kubernetes:master Feb 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants