Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for launch configurations #10937

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Remove support for launch configurations #10937

merged 1 commit into from
Mar 9, 2021

Conversation

bharath-123
Copy link
Contributor

@bharath-123 bharath-123 commented Feb 26, 2021 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2021
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Feb 26, 2021
@hakman hakman changed the title Remove LaunchTemplate behind feature flag [LC deprecation 1] Remove support for launch configurations Feb 27, 2021
@hakman
Copy link
Member

hakman commented Feb 27, 2021

Not sure if there is a need to have multiple PRs for this. Should be reasonably simple to remove support for launch configurations.

@bharath-123 bharath-123 force-pushed the feat/deprecate-launch-config branch from 243b380 to 469201a Compare March 1, 2021 18:10
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2021
@bharath-123 bharath-123 force-pushed the feat/deprecate-launch-config branch 2 times, most recently from 7862da4 to 94b5220 Compare March 2, 2021 09:18
@bharath-123
Copy link
Contributor Author

This should be good for a review. Would love some feedback on the integration tests related changes.

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman March 3, 2021 18:24
@hakman
Copy link
Member

hakman commented Mar 3, 2021

This should be good for a review. Would love some feedback on the integration tests related changes.

I think the LT integration test should be removed completely. As everything uses LT now, it should be no longer needed.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2021
@bharath-123
Copy link
Contributor Author

This should be good for a review. Would love some feedback on the integration tests related changes.

I think the LT integration test should be removed completely. As everything uses LT now, it should be no longer needed.

agreed. will do that.

@bharath-123 bharath-123 force-pushed the feat/deprecate-launch-config branch 3 times, most recently from 7fb8c30 to 39fc124 Compare March 8, 2021 19:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021
@hakman hakman force-pushed the feat/deprecate-launch-config branch from 39fc124 to 0c0767c Compare March 9, 2021 07:09
@hakman
Copy link
Member

hakman commented Mar 9, 2021 •
edited
Loading

You were right, RootVolumeDeleteOnTermination had to be deprecated and ignored. I just removed that to speed things up as it was my mistake.
Thanks for the effort here. It will make things easier to maintain for the AWS implementation.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 681e869 into kubernetes:master Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@rifelpet
Copy link
Member

rifelpet commented Mar 9, 2021

We should probably have a release note for this.

@bharath-123
Copy link
Contributor Author

@rifelpet I have already added this to the 1.21 release notes :)

@rifelpet
Copy link
Member

rifelpet commented Mar 9, 2021

I don't see anything in here mentioning that launch configuration support has been removed: https://github.com/kubernetes/kops/blob/master/docs/releases/1.21-NOTES.md it should probably be in one of the first few sections in the docs rather than just a bullet point for the PR

This was referenced Mar 12, 2021
Closed
Closed
This was referenced Apr 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet left review comments

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@bharath-123 @hakman @k8s-ci-robot @rifelpet