-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering issue created by #10414 #10700
Conversation
Hi @avdhoot. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @avdhoot. Please also bump the manifest version here to 3.17.1-kops.3
:
"k8s-1.16": "3.17.1-kops.2", |
Looks good. One more thing, if you don't mind, could you squash the 2 commits? |
f9bc151
to
0717e4a
Compare
@hakman Sorry took time to understand local |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avdhoot, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This might break upgrade if cluster spec have
prometheusMetricsEnabled: true
. I have validated this by upgrading our cluster. This is caused by #10414