Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups: stop flapping #4114

Merged
merged 1 commit into from
Aug 20, 2022
Merged

groups: stop flapping #4114

merged 1 commit into from
Aug 20, 2022

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 20, 2022 •
edited
Loading

Trying to get https://testgrid.k8s.io/sig-k8s-infra-groups back to green

This reverts #3132

Google Workspace used to silently convert this gmail address to a
googlemail address, now it appears to be doing this opposite. Every
other run fails trying to add the unconverted address, and removes the
converted address.

@spiffxp
groups: stop flapping
4c64f7d 
This reverts e7045ea

Google Workspace used to silently convert this gmail address to a
googlemail address, now it appears to be doing this opposite. Every
other run fails trying to add the unconverted address, and removes the
converted address.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/access Define who has access to what via IAM bindings, role bindings, policy, etc. label Aug 20, 2022
@k8s-ci-robot k8s-ci-robot added area/groups Google Groups management, code in groups/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Aug 20, 2022
@dims
Copy link
Member

dims commented Aug 20, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 79c673e into kubernetes:main Aug 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 20, 2022
@spiffxp spiffxp deleted the flapping-groups-job branch August 22, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @dims