Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups: fix googlemail address #3132

Merged
merged 1 commit into from
Nov 30, 2021
Merged

groups: fix googlemail address #3132

merged 1 commit into from
Nov 30, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Nov 30, 2021

Related:

The groups CI job continues to flake in this way:

  • first run: adds this gmail.com address, which Workspace converts to a googlemail.com address
  • next run:
    • tries adding the gmail address, which fails, because Workspace knows it's actually the googlemail.com address
    • removes the googlemail.com address, because it's not in groups.yaml

I have tried playing with the API and can't see the mapping that Workspace apparently sees. So, "fix" the "glitch" by converting to the e-mail address that Workspace uses

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Nov 30, 2021
@ameukam
Copy link
Member

ameukam commented Nov 30, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4384ed1 into kubernetes:main Nov 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Nov 30, 2021
@spiffxp spiffxp deleted the fix-googlemail-address branch November 30, 2021 20:18
@spiffxp spiffxp mentioned this pull request Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @ameukam