-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate path types #9967
Validate path types #9967
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Jintao Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Please cancel the hold, if you wish to.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@strongjz has the final hold cancel |
/hold cancel |
What this PR does / why we need it:
Adds validation on the path vs pathType used.
This is a new config on Ingress configmap that is disabled by default (but should be enabled on the next minor version, like v1.8).
When this option is enabled, the path will be validated and the only allowed characters will be "A-Za-z0-9/_-" when the pathType is not ImplementationSpecific.
Cluster admins should validate when users can use ImplementationSpecific, and if there is some dangerous character being used.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Added unit tests on validator, added e2e tests containing valid and invalid scenarios