Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nginx-ingress helm chart version to 4.7.0 #4080

Conversation

jenkins-infra-updatecli[bot]
Copy link
Contributor

Bump nginx-ingress helm chart

Update the version of the Helm chart ingress-nginx

Updated to content "" in file "clusters/doks-public.yaml" Updated to content "" in file "clusters/eks-public.yaml" Updated to content "" in file "clusters/privatek8s.yaml" Updated to content "" in file "clusters/publick8s.yaml"

4.7.0
Remark: We couldn't identify a way to automatically retrieve changelog information.
Please use following information to take informed decision

Helm Chart: ingress-nginx
Ingress controller for Kubernetes using NGINX as a reverse proxy and load balancer
Project Home: https://github.com/kubernetes/ingress-nginx
Require Kubernetes Version: >=1.20.0-0
Version created on the 2023-05-30 18:41:21.835828446 +0000 UTC

Sources:

* https://github.com/kubernetes/ingress-nginx



URL:

* https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.7.0/ingress-nginx-4.7.0.tgz



Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

Updated to content "" in file "clusters/eks-public.yaml"

Updated to content "" in file "clusters/privatek8s.yaml"

Updated to content "" in file "clusters/publick8s.yaml"

Made with ❤️️ by updatecli
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will break the mirrorbits release as per kubernetes/ingress-nginx#9967.

We have

- backend:
            service:
              name: mirrorbits
              port:
                number: 80
          path: /.*[.](deb|hpi|war|rpm|msi|pkg|sha256|md5sum|zip|gz|pdf|json|svg|sh|jpeg|ico|png|html)$
          pathType: Prefix

=> gotta check on a local k3s and issue a PR to update the helm chart (should be implementation specific)

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the path type validation with a local k3d cluster and deploying public-nginx ingress and mirrorbits: the strict validation is not enabled by default and the path for mirrorbits are kept.

Please note that we still need to update mirrorbits chart as strict validation fails with the "Prefix" PathType though

@dduportal dduportal merged commit 61c8584 into main Jun 23, 2023
@dduportal dduportal deleted the updatecli_811453c5578dba938a873475b04f25bead281c4f29d38d335929b7d3b9fab50e branch June 23, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants