Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumped kind version to 0.14.0 in CI #8677

Merged
merged 1 commit into from
Jun 7, 2022
Merged

bumped kind version to 0.14.0 in CI #8677

merged 1 commit into from
Jun 7, 2022

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented Jun 7, 2022 •
edited
Loading

What this PR does / why we need it:

  • Some parts of CI were not changed to use kind v0.14.0 so changed that
  • CI is failing for K8S v1.24 so checking if this will fix those failures

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

  • Can be tested in CI only because of GHActions

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

@longwuyuan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from rikatz and strongjz June 7, 2022 15:26
@longwuyuan
Copy link
Contributor Author

longwuyuan commented Jun 7, 2022 •
edited
Loading

/triage accepted
/priority important-soon
/assign @rikatz @strongjz @tao12345666333

Please check/review/approve soon as CI is failing for K8S v1.24 in the section where Kind v0.12.0 is used

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Jun 7, 2022
@longwuyuan longwuyuan mentioned this pull request Jun 7, 2022
Merged
9 tasks
tao12345666333
tao12345666333 reviewed Jun 7, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
tao12345666333
tao12345666333 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit fb2f00b into kubernetes:main Jun 7, 2022
@longwuyuan longwuyuan deleted the bump-kind branch June 7, 2022 16:16
@phantooom
Copy link
Contributor

e2e test still failed

@longwuyuan
Copy link
Contributor Author

root-cause is worker node not joining. Happening even on local dev environment.

@longwuyuan
Copy link
Contributor Author

kubernetes-sigs/kind#2798

@longwuyuan longwuyuan mentioned this pull request Jun 9, 2022
Merged
9 tasks
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@longwuyuan @rchshld
bumped kind version to 0.14.0 (kubernetes#8677)
a02c7e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@rikatz rikatz Awaiting requested review from rikatz

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

@tao12345666333 tao12345666333

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@longwuyuan @k8s-ci-robot @phantooom @tao12345666333 @strongjz @rikatz