Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade CI kind testing so we test against k8s 1.24 #8655

Closed
strongjz opened this issue May 31, 2022 · 8 comments · Fixed by #8656
Closed

Upgrade CI kind testing so we test against k8s 1.24 #8655

strongjz opened this issue May 31, 2022 · 8 comments · Fixed by #8656
Assignees
@Ab-hishek
Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@strongjz
Copy link
Member

Need to upgrade kind testing to v0.14.0 so we can test against k8s 1.24 releases

https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/ci.yaml#L223

/kind feature
/good-first-issue
/priority backlog
/triage accepted
@strongjz strongjz added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2022
@k8s-ci-robot
Copy link
Contributor

@strongjz:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Need to upgrade kind testing to v0.14.0 so we can test against k8s 1.24 releases

https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/ci.yaml#L223

/kind feature
/good-first-issue
/priority backlog
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 31, 2022
@Ab-hishek
Copy link
Contributor

/assign

@Ab-hishek Ab-hishek mentioned this issue May 31, 2022
Merged
9 tasks
@longwuyuan
Copy link
Contributor

As per @tao12345666333 we are not ready for K8S version 1.24 #8667 (comment)

Why are we testing against K8S v1,24 if code is not ready for K8S v1.24 because of #8091

We even merged the PR that added K8S v1.24 to the ci.yaml matrix and co-incidentally all CI runs are failing on K8S v1.24 on main.

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

@longwuyuan: Reopened this issue.

In response to this:

As per @tao12345666333 we are not ready for K8S version 1.24 #8667 (comment)

Why are we testing against K8S v1,24 if code is not ready for K8S v1.24 because of #8091

We even merged the PR that added K8S v1.24 to the ci.yaml matrix and co-incidentally all CI runs are failing on K8S v1.24 on main.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@longwuyuan
Copy link
Contributor

@Ab-hishek can you please look at the failing CI jobs for K8S v1.24. We have a slack discussion ongoing as well https://kubernetes.slack.com/archives/C021E147ZA4/p1654602861402769thread_ts=1654602027.797439&cid=C021E147ZA4

@longwuyuan longwuyuan mentioned this issue Jun 7, 2022
Merged
9 tasks
@longwuyuan
Copy link
Contributor

/area stabilization

@k8s-ci-robot k8s-ci-robot added the area/stabilization Work for increasing stabilization of the ingress-nginx codebase label Jun 27, 2022
@strongjz
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@strongjz: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ab-hishek Ab-hishek

Labels
area/stabilization Work for increasing stabilization of the ingress-nginx codebase good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update ci kind version to v0.14.0 Ab-hishek/ingress-nginx
4 participants
@strongjz @longwuyuan @k8s-ci-robot @Ab-hishek