Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux node selector as default #7481

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Add linux node selector as default #7481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions charts/ingress-nginx/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,8 @@ controller:
##
priorityClassName: ""
podAnnotations: {}
nodeSelector: {}
nodeSelector:
kubernetes.io/os: linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be set as the default value, and this may affect users who do not have this label

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you only have linux nodes this setting has no effect. Also this has already been done for one field in PR #6305 and did not affect existing users. Could you please elaborate on in which scenario it would affect existing users?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense, as the other componentes (ingress, default-backend) also have the nodeSelector.

Let's release the CI, and watch :)

tolerations: []
runAsUser: 2000

Expand Down Expand Up @@ -732,7 +733,8 @@ defaultBackend:
## Node labels for default backend pod assignment
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: {}
nodeSelector:
kubernetes.io/os: linux

## Annotations to be added to default backend pods
##
Expand Down