Add linux node selector as default #7481

jonaskello · 2021-08-11T12:12:12Z

What this PR does / why we need it:

To stop pods from starting on Windows nodes (as they cannot run there)

Types of changes

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By manual override of values.yaml

k8s-ci-robot · 2021-08-11T12:12:14Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-08-11T12:12:18Z

@jonaskello: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-08-11T12:12:19Z

Welcome @jonaskello!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-11T12:12:19Z

Hi @jonaskello. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jonaskello · 2021-08-11T12:20:16Z

I signed it

jonaskello · 2021-08-11T12:20:46Z

/assign @cpanato

tao12345666333 · 2021-08-11T12:27:42Z

charts/ingress-nginx/values.yaml

@@ -555,7 +555,8 @@ controller:
      ##
      priorityClassName: ""
      podAnnotations: {}
-      nodeSelector: {}
+      nodeSelector:
+        kubernetes.io/os: linux


I don't think this should be set as the default value, and this may affect users who do not have this label

If you only have linux nodes this setting has no effect. Also this has already been done for one field in PR #6305 and did not affect existing users. Could you please elaborate on in which scenario it would affect existing users?

I guess it makes sense, as the other componentes (ingress, default-backend) also have the nodeSelector.

Let's release the CI, and watch :)

rikatz · 2021-08-12T18:17:54Z

/ok-to-test

rikatz · 2021-08-12T18:34:34Z

/lgtm
/approve
Thanks

rikatz · 2021-08-12T18:39:23Z

/approve cancel

rikatz · 2021-08-12T18:40:10Z

@jonaskello need to fix your commit message, please rebase it and remove the commit message.

Thanks!

rikatz · 2021-08-12T18:41:35Z

(btw you need to remove "Fixes #7480" from your commit message)

jonaskello · 2021-08-12T19:07:02Z

@rikatz The commit message should be fixed now :-)

rikatz · 2021-08-12T19:09:39Z

/approve
Thanks

rikatz · 2021-08-12T19:09:59Z

/hold
Until CI passes

rikatz · 2021-08-12T19:20:12Z

/hold cancel

rikatz · 2021-08-12T19:39:11Z

/lgtm

k8s-ci-robot · 2021-08-12T19:39:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonaskello, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~charts/ingress-nginx/OWNERS~~ [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 11, 2021

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 11, 2021

k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 11, 2021

k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2021

k8s-ci-robot requested review from ChiefAlexander and cpanato August 11, 2021 12:12

k8s-ci-robot added the area/helm Issues or PRs related to helm charts label Aug 11, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 11, 2021

k8s-ci-robot assigned cpanato Aug 11, 2021

tao12345666333 requested changes Aug 11, 2021

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2021

k8s-ci-robot assigned rikatz Aug 12, 2021

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2021

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021

Add linux node selector as default

8081c6a

jonaskello force-pushed the patch-1 branch from 6b5e9c2 to 8081c6a Compare August 12, 2021 19:06

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Aug 12, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2021

k8s-ci-robot merged commit 2fe8270 into kubernetes:main Aug 12, 2021

jonaskello deleted the patch-1 branch August 12, 2021 19:46

longwuyuan mentioned this pull request Aug 13, 2021

Jobs still starting on Windows nodes #7480

Closed

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023

Add linux node selector as default (kubernetes#7481)

43405cb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add linux node selector as default #7481

Add linux node selector as default #7481

jonaskello commented Aug 11, 2021 •

edited

Loading

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

jonaskello commented Aug 11, 2021

jonaskello commented Aug 11, 2021

tao12345666333 Aug 11, 2021

jonaskello Aug 11, 2021

rikatz Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

jonaskello commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

Add linux node selector as default #7481

Add linux node selector as default #7481

Conversation

jonaskello commented Aug 11, 2021 • edited Loading

What this PR does / why we need it:

Types of changes

How Has This Been Tested?

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

k8s-ci-robot commented Aug 11, 2021

jonaskello commented Aug 11, 2021

jonaskello commented Aug 11, 2021

tao12345666333 Aug 11, 2021

Choose a reason for hiding this comment

jonaskello Aug 11, 2021

Choose a reason for hiding this comment

rikatz Aug 12, 2021

Choose a reason for hiding this comment

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

jonaskello commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

rikatz commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

jonaskello commented Aug 11, 2021 •

edited

Loading