-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace non-existent curl image #7309
Conversation
The tutum/curl image no longer exists, the official curl image from https://github.com/curl/curl-docker is curlimages/curl, and it works with the demo instructions above.
Welcome @mysticaltech! |
Hi @mysticaltech. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mysticaltech The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I remember there was already a PR for this. |
#7224 <- is a dup |
Thanks, I tried to find it but couldn't find it 😂 Let's close this. @mysticaltech Thanks for your contribution! /close |
@tao12345666333: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey folks, pleasure, but I changed a lot fewer things than #7224, just the missing image. So kind of a dupe, but way leaner! |
The tutum/curl image no longer exists, the official curl image from https://github.com/curl/curl-docker is curlimages/curl, and it works with the demo instructions above.
What this PR does / why we need it:
It will ease the use of the demo, and allow for copy-pasting of working commands.
Types of changes
Broken container image replacement
Which issue/s this PR fixes
None that I know of.
How Has This Been Tested?
Yes tested, works with the same instructions, only the container image needs to change.
Checklist: