Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs：update troubleshooting.md #7224

Merged
merged 6 commits into from
Jul 27, 2021
Merged

docs：update troubleshooting.md #7224

merged 6 commits into from
Jul 27, 2021

Conversation

unacceptable
Copy link
Contributor

@unacceptable unacceptable commented Jun 9, 2021 •
edited
Loading

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@unacceptable
Update troubleshooting.md
2799de3 
Made the troubleshooting steps a bit more fluid IMHO.
@unacceptable
Update troubleshooting.md
f2224b6 
Fixed introduced troubleshooting workflow change.
@unacceptable
Update troubleshooting.md
22d26ec 
Fixed token path in new proposed workflow.
@unacceptable
Update troubleshooting.md
0a35cc3 
Fixed terminology (pod vs. container)
@unacceptable
Changed verb to get CLA refresh.
85c6821
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @unacceptable. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from cmluciano and rikatz June 9, 2021 05:31
rikatz
rikatz reviewed Jun 9, 2021
View reviewed changes
docs/troubleshooting.md Outdated Show resolved Hide resolved
rikatz
rikatz reviewed Jun 9, 2021
View reviewed changes
docs/troubleshooting.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2021
@rikatz
Copy link
Contributor

rikatz commented Jun 27, 2021

Hi,

Please:

  • Rebase the PR
  • Re-title it to proper reflect what it does
  • Fill the PR template with the what it does, why we need this, etc
    Thanks

@rikatz rikatz mentioned this pull request Jul 1, 2021
Closed
5 tasks
@tao12345666333
Copy link
Member

tao12345666333 commented Jul 1, 2021 •
edited
Loading

/retitle docs：update troubleshooting.md

@rikatz rikatz changed the base branch from master to main July 16, 2021 13:14
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2021
@strongjz
Copy link
Member

/retitle docs：update troubleshooting.md

@k8s-ci-robot k8s-ci-robot changed the title Patch 1 docs：update troubleshooting.md Jul 17, 2021
@rikatz
Copy link
Contributor

rikatz commented Jul 27, 2021

/ok-to-test
/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, unacceptable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit c4cc9a5 into kubernetes:main Jul 27, 2021
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@unacceptable @rchshld
docs：update troubleshooting.md (kubernetes#7224)
2678f11 
* Update troubleshooting.md

Made the troubleshooting steps a bit more fluid IMHO.

* Update troubleshooting.md

Fixed introduced troubleshooting workflow change.

* Update troubleshooting.md

Fixed token path in new proposed workflow.

* Update troubleshooting.md

Fixed terminology (pod vs. container)

* Changed verb to get CLA refresh.

* Updating PR with requested changes.

Signed-off-by: Robert Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz left review comments

@tao12345666333 tao12345666333 tao12345666333 left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@unacceptable @k8s-ci-robot @rikatz @tao12345666333 @strongjz