regression test and fix for duplicate hsts bug #4826
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #4826 +/- ##
=========================================
Coverage ? 58.47%
=========================================
Files ? 88
Lines ? 6717
Branches ? 0
=========================================
Hits ? 3928
Misses ? 2361
Partials ? 428Continue to review full report at Codecov.
|
ElvinEfendi
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
ElvinEfendi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -36,7 +36,8 @@ DEV_IMAGE=${REGISTRY}/nginx-ingress-controller:${TAG} | |||
| { [ "$(minikube status | grep -c Running)" -ge 2 ] && minikube status | grep -qE ': Configured$|Correctly Configured'; } \ | |||
| || minikube start \ | |||
| --extra-config=kubelet.sync-frequency=1s \ | |||
| --extra-config=apiserver.authorization-mode=RBAC | |||
| --extra-config=apiserver.authorization-mode=RBAC \ | |||
| --kubernetes-version=v1.15.0 | |||
There was a problem hiding this comment.
TODO: this can be removed once we stop testing k8s 1.12 and 1.13
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #4739Special notes for your reviewer: