Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated strict-transport-security header #4739

Closed
aledbf opened this issue Nov 6, 2019 · 1 comment · Fixed by #4826
Closed

Duplicated strict-transport-security header #4739

aledbf opened this issue Nov 6, 2019 · 1 comment · Fixed by #4826
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@aledbf
Copy link
Member

aledbf commented Nov 6, 2019

NGINX Ingress controller version: 0.26.0 and 0.26.1
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.2", GitCommit:"66049e3b21efe110454d67df4fa62b08ea79a19b", GitTreeState:"clean", BuildDate:"2019-05-16T16:23:09Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Environment:

  • Cloud provider or hardware configuration: AWS
  • OS (e.g. from /etc/os-release):
NAME="Flatcar Linux by Kinvolk"
VERSION=2247.5.0
PRETTY_NAME="Flatcar Linux by Kinvolk 2247.5.0 (Rhyolite)"
HOME_URL="https://flatcar-linux.org/"
  • Kernel (e.g. uname -a): Linux 4.19.78-flatcar
  • Install tools: Typhoon

What happened:

PR #4601 introduced a duplication in the header strict-transport-security. The behavior is no the same as before when more_set_headers was used.

What you expected to happen:

Only one strict-transport-security header

How to reproduce it (as minimally and precisely as possible):

Any Ingress with TLS correctly configured and a service that also returns the header strict-transport-security returns two instead of just one instance of the header.

@aledbf
Copy link
Member Author

aledbf commented Nov 6, 2019

/assign @ElvinEfendi

@aledbf aledbf added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants