Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes a mismatch between Makefile
MULTI_ARCH_IMAGE
andDEV_IMAGE
used indev-env.sh
While running
build/dev-env.sh
, it builds the appropriate container using https://github.com/kubernetes/ingress-nginx/blob/master/build/dev-env.sh#L46Then, it replaces the image name in deployment files https://github.com/kubernetes/ingress-nginx/blob/master/build/dev-env.sh#L68
But currently,
DEV_IMAGE
does not depend onARCH
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
I'm a bit confused about why this hasn't been seen sooner.
Cc @ElvinEfendi