Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev-env image name #4411

Closed
wants to merge 1 commit into from
Closed

Fix dev-env image name #4411

wants to merge 1 commit into from

Conversation

wayt
Copy link
Contributor

@wayt wayt commented Aug 7, 2019

What this PR does / why we need it:

This fixes a mismatch between Makefile MULTI_ARCH_IMAGE and DEV_IMAGE used in dev-env.sh

While running build/dev-env.sh, it builds the appropriate container using https://github.com/kubernetes/ingress-nginx/blob/master/build/dev-env.sh#L46

Then, it replaces the image name in deployment files https://github.com/kubernetes/ingress-nginx/blob/master/build/dev-env.sh#L68

But currently, DEV_IMAGE does not depend on ARCH.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

I'm a bit confused about why this hasn't been seen sooner.

Cc @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wayt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayt
To complete the pull request process, please assign bowei
You can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wayt wayt mentioned this pull request Aug 7, 2019
@wayt
Copy link
Contributor Author

wayt commented Aug 8, 2019

/assign @bowei

@aledbf
Copy link
Member

aledbf commented Aug 15, 2019

@ElvinEfendi is this still necessary?

@wayt
Copy link
Contributor Author

wayt commented Aug 15, 2019

I think Elvin's changes fixed that, we can close

@wayt wayt closed this Aug 15, 2019
@wayt wayt deleted the dev-env branch August 15, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants