Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev-env script #4410

Merged
merged 1 commit into from
Aug 8, 2019
Merged

fix dev-env script #4410

merged 1 commit into from
Aug 8, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
dev-env script is currently broken and does not detect minikube status correctly and therefore does not start it. The PR fixes that.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei August 7, 2019 18:46
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@aledbf
Copy link
Member

aledbf commented Aug 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@ElvinEfendi
Copy link
Member Author

/hold

there's more things broken with the script

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@wayt
Copy link
Contributor

wayt commented Aug 7, 2019

@ElvinEfendi There is also an issue with image names, see #4411

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2019
@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

@ElvinEfendi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@codecov-io
Copy link

Codecov Report

Merging #4410 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4410      +/-   ##
==========================================
+ Coverage   58.63%   58.68%   +0.04%     
==========================================
  Files          88       88              
  Lines        6569     6569              
==========================================
+ Hits         3852     3855       +3     
+ Misses       2288     2285       -3     
  Partials      429      429
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041a845...c898ad6. Read the comment docs.

@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

1 similar comment
@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

@aledbf
Copy link
Member

aledbf commented Aug 7, 2019

/test pull-ingress-nginx-e2e-1-15

@aledbf
Copy link
Member

aledbf commented Aug 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f98de5 into kubernetes:master Aug 8, 2019
@ElvinEfendi ElvinEfendi deleted the fix-dev-script branch August 8, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants