-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dev-env script #4410
fix dev-env script #4410
Conversation
/lgtm |
/hold there's more things broken with the script |
@ElvinEfendi There is also an issue with image names, see #4411 |
/test pull-ingress-nginx-test |
/hold cancel |
Codecov Report
@@ Coverage Diff @@
## master #4410 +/- ##
==========================================
+ Coverage 58.63% 58.68% +0.04%
==========================================
Files 88 88
Lines 6569 6569
==========================================
+ Hits 3852 3855 +3
+ Misses 2288 2285 -3
Partials 429 429
Continue to review full report at Codecov.
|
/test pull-ingress-nginx-test |
1 similar comment
/test pull-ingress-nginx-test |
/test pull-ingress-nginx-e2e-1-15 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
dev-env script is currently broken and does not detect minikube status correctly and therefore does not start it. The PR fixes that.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: