Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test to make sure dynamic cert works trailing dot in domains #4249

Merged
merged 1 commit into from
Jun 29, 2019
Merged

test to make sure dynamic cert works trailing dot in domains #4249

merged 1 commit into from
Jun 29, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4243

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei June 28, 2019 20:23
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #4249 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4249      +/-   ##
==========================================
- Coverage    57.9%   57.88%   -0.02%     
==========================================
  Files          87       87              
  Lines        6544     6544              
==========================================
- Hits         3789     3788       -1     
- Misses       2324     2326       +2     
+ Partials      431      430       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d8ce7...f771e72. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 28, 2019

/retest

@aledbf
Copy link
Member

aledbf commented Jun 29, 2019

@ElvinEfendi
Copy link
Member Author

@aledbf ensureHTTPSRequest checks that already

@aledbf
Copy link
Member

aledbf commented Jun 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a200948 into kubernetes:master Jun 29, 2019
@ElvinEfendi
Copy link
Member Author

This was not supposed to be merged, my bad for not marking it as work in progress. I will revert and continue working on this.

I was expecting the test to fail.

@ElvinEfendi ElvinEfendi deleted the trailing-dot branch July 4, 2019 21:29
@ElvinEfendi
Copy link
Member Author

#4274 is the actual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certificate Errors for requests sent with FQDN (broke on move from 0.23.0 to 0.24.0)
4 participants