-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test to make sure dynamic cert works trailing dot in domains #4249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4249 +/- ##
==========================================
- Coverage 57.9% 57.88% -0.02%
==========================================
Files 87 87
Lines 6544 6544
==========================================
- Hits 3789 3788 -1
- Misses 2324 2326 +2
+ Partials 431 430 -1
Continue to review full report at Codecov.
|
/retest |
@ElvinEfendi please add something like this check https://github.com/kubernetes/ingress-nginx/blob/master/test/e2e/leaks/lua_ssl.go#L101 |
@aledbf |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was not supposed to be merged, my bad for not marking it as work in progress. I will revert and continue working on this. I was expecting the test to fail. |
#4274 is the actual fix. |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #4243Special notes for your reviewer: