Merge pull request #4249 from ElvinEfendi/trailing-dot

test to make sure dynamic cert works trailing dot in domains
kubernetes · Jun 29, 2019 · a200948 · a200948
2 parents ac9f250 + f771e72
commit a200948
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/test/e2e/lua/dynamic_certificates.go b/test/e2e/lua/dynamic_certificates.go
@@ -130,6 +130,10 @@ var _ = framework.IngressNginxDescribe("Dynamic Certificate", func() {
 			ensureHTTPSRequest(f.GetURL(framework.HTTPS), host, host)
 		})
 
+		It("supports requests with domain with trailing dot", func() {
+			ensureHTTPSRequest(f.GetURL(framework.HTTPS), host+".", host)
+		})
+
 		It("picks up the updated certificate without reloading", func() {
 			ing, err := f.KubeClientSet.ExtensionsV1beta1().Ingresses(f.Namespace).Get(host, metav1.GetOptions{})
 			Expect(err).ToNot(HaveOccurred())