Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some configuration logic from Nginx config to Lua code #3798

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Move some configuration logic from Nginx config to Lua code #3798

merged 1 commit into from
Mar 31, 2019

Conversation

ElvinEfendi
Copy link
Member

@ElvinEfendi ElvinEfendi commented Feb 21, 2019

What this PR does / why we need it:

  • use Lua code to do some conditional variable assignments instead of Nginx's map directive
  • move HTTP to HTTPs redirection logic to Lua

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #3790

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei February 21, 2019 22:32
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@aledbf
Copy link
Member

aledbf commented Feb 21, 2019

@ElvinEfendi please no. Migrating to lua will reduce the number of users that can customize the configuration. I think we need to rethink the map part but no in this way

@ElvinEfendi
Copy link
Member Author

ElvinEfendi commented Feb 21, 2019

If you ask me Lua code is easier to understand (also easier to test) than that complicated maps and ifs we do in the configuration. I'll leave this here to sink a bit, maybe we will reconsider :)

And we can simplify the hell out of the existing Lua code - it was done in under 5m, literally translated the maps into Lua code.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2019
@aledbf
Copy link
Member

aledbf commented Mar 28, 2019

I change my last comment because we keep seeing use cases that are not possible to support using map and if. For that reason, I think this could be a good idea to at least try.

@ElvinEfendi ElvinEfendi changed the title [WIP] move rewrite part from config to lua Move some configuration logic from Nginx config to Lua code Mar 31, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2019
@aledbf
Copy link
Member

aledbf commented Mar 31, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host header copied from X-Forwarded-Host (when forwarded headers are enabled)
3 participants