-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some configuration logic from Nginx config to Lua code #3798
Move some configuration logic from Nginx config to Lua code #3798
Conversation
|
If you ask me Lua code is easier to understand (also easier to test) than that complicated And we can simplify the hell out of the existing Lua code - it was done in under 5m, literally translated the maps into Lua code. |
I change my last comment because we keep seeing use cases that are not possible to support using map and if. For that reason, I think this could be a good idea to at least try. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
map
directiveWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3790Special notes for your reviewer: