Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: cleanup all the maps in configuration using Lua #3797

Closed
ElvinEfendi opened this issue Feb 21, 2019 · 3 comments
Closed

Refactoring: cleanup all the maps in configuration using Lua #3797

ElvinEfendi opened this issue Feb 21, 2019 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ElvinEfendi
Copy link
Member

It's hard to wrap your head around currently in the Nginx configuration template and map is limited.

We can introduce a new Lua middleware to take care of i.e setting $best_http_host and all the other similar variables. To do that we should make sure configmap settings are synced to Lua and stored in the configuration_data shared dictionary. We can then introduce rewrite_by_lua_block phase in http section and call this new Lua middleware there.

@aledbf
Copy link
Member

aledbf commented Feb 21, 2019

We can introduce a new Lua middleware to take care of i.e setting $best_http_host and all the other similar variables.

One of the reasons why I want a kubectl plugin for ingress-nginx is to be able to install the controller previous inspection of the cluster. This can help us to introduce the concept of “profiles” to handle the behavior of the headers. The goal is to remove the existing logic in the template, having a simple definition, also allowing the use of the definition of custom behavior

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2019
@ElvinEfendi
Copy link
Member Author

With #3798 we have converted significant number of map's to Lua rewrite code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants