Move issues and prs over from contrib/ingress #3

bprashanth · 2016-11-10T18:40:47Z

As the title suggests. See tools like https://github.com/google/github-issue-mover

porridge · 2016-11-25T13:00:48Z

Issues sound straightforward (once we have a list of all that apply).
However PRs refer to commits, which are against a different directory hierarchy... @bprashanth do you think we should try to rewrite them?

bprashanth · 2016-11-26T03:44:20Z

I think just issues are fine actually. By "move prs" I meant ping the original pr saying we aren't accepting ingress code in contrib anymore and close it with a pointer to this repo. Before we do that we should probably write a doc on how we expect people to integrate with the generic controller, because some prs in contrib are submitting a custom ingress controller, which right now should just become a backed implementing the interface.

porridge · 2016-11-28T10:15:01Z

OK, you can assign this one to me, then.

aledbf · 2016-11-29T13:57:33Z

@porridge this is the list of issues to move from contrib:

aledbf · 2016-11-29T13:58:19Z

Before we do that we should probably write a doc on how we expect people to integrate with the generic controller, because some prs in contrib are submitting a custom ingress controller, which right now should just become a backed implementing the interface.

before that :) we need to publish the examples and the configuration guide that was removed

Edit: this is the list of PR to close (only related to nginx)

kubernetes-retired/contrib#2368
kubernetes-retired/contrib#2324
kubernetes-retired/contrib#2319
kubernetes-retired/contrib#2204
kubernetes-retired/contrib#2072
kubernetes-retired/contrib#1991
kubernetes-retired/contrib#1943
kubernetes-retired/contrib#1944
kubernetes-retired/contrib#1934
kubernetes-retired/contrib#1880
kubernetes-retired/contrib#1760

porridge · 2016-11-29T14:04:27Z

Two questions about timing: 1) Do you think we should couple PR and issue move? I.e. wait with moving issues until we're ready to also close PRs in contrib/? 2) Also, unless github.com/kubernetes/contrib/ingress/ gets deleted really soon after the above move, we'll keep getting new issues and PRs in contrib/ - so would you rather do another followup move later, or delay the move until contrib/ingress is gone?

aledbf · 2016-11-29T14:23:46Z

@porridge I think we need to restore the docs first.
After that move the issues (some can be closed but I don't have privileges in contrib) and then the PRs
Until we release a new version of the nginx ingress controller from this repository we cannot remove the code and docs from contrib (after the release is possible to open a PR that removes all the ingress code and just leave a README.md with information about the new this repo)

bprashanth · 2016-11-29T16:42:32Z

We also can't delete the contrib repo because it's linked from older relese documentation on k8s.io, suggest keeping it around for a while with a big notice in the readme linking to this repo.

Re examples, we should start doing this #9 (comment)

porridge · 2016-12-02T10:56:50Z

@bprashanth regarding the "older release documentation on k8s.io" do you mean it points to contrib/ingress at the tip of master? Can you show examples? If it points at individual files, I guess we need to keep the source. However if it points at the directory in general, then I guess we could just leave around a README with links to two places:

for old code released in , see
for current development, see

porridge · 2016-12-02T11:23:03Z

Doing all of #9 seems like a major undertaking, so I'd like us to agree here on the minimum that needs to be done in order to unblock this issue.

I think that:

make the configuration guide + examples only as good as they were for contrib/ingress, plus
write a doc on how we expect people to integrate with the generic controller (BTW, does this deserve its own issue?)

should be enough.

Rationale: we should not make things worse with the move, but we also cannot expect to improve everything straight away.

@bprashanth WDYT?
@aledbf you mentioned some documentation was deleted, can you point me at the commit which did that, or at least at the URL they were visible at? I'd like to see what the scope and level of detail was and/or salvage what makes sense.

aledbf · 2016-12-02T12:14:18Z

https://github.com/kubernetes/contrib/blob/master/ingress/controllers/nginx/README.md
https://github.com/kubernetes/contrib/blob/master/ingress/controllers/nginx/configuration.md

bprashanth · 2016-12-02T21:54:26Z

I was planning to fill in text for all the READMEs added in this pr https://github.com/kubernetes/ingress/pull/33/files

This basically gives us 3 tasks:

deleveloper docs: how to write a generic controller and other patterns (ingress controllers that use svc vip, svc DNS, go straight to endpoints; basically stuff that anyone writing a controller should be aware of)
admin docs: different deployment styles and tradeoffs (does one use a deployment/daemonset, keepalive vs service vip, cloud vs local etc. Discussion on Documentation: setting up ingress on metal with the right, secure CNI configuration #17, Bare-metal Ingress HA using keepalived #23 might help. This is stuff anyone picking one of the other existing controllers should be aware of)
examples: add a folder per example listed in https://github.com/kubernetes/ingress/tree/master/docs/example that contains a <backend_name>.md file showing how to perform the given task via a given backend. A lot of these can be ported over from contrib, but some of them need to be written (eg: pipelining ingress controllers). If a given example doesn't work on say, GCE, the eg stick-sessions/gce.md file should say something to the effect of "you need to pipeline an nginx controller behind the gce lb to achieve this, heres a link to how to do that"

I think a lot of confusion comes from us having a cross platform api, but actually documenting it as distinct implementations, instead of taking a more wholeistic view.

Rationale: we should not make things worse with the move, but we also cannot expect to improve everything straight away.

@porridge I agree with this to some extent, but at the same time we have a chance to slowly improve things as we move and I fear that just lifting and shifting will lead to 0 improvement.

bprashanth · 2016-12-02T22:00:03Z

we have #9 for examples, filed #40 and
#41 for the other 2. Please feel free to comment and take any of them, I'm also going to start chipping away at the examples.

mrmm · 2016-12-09T10:28:16Z

Hi @bprashanth @aledbf @porridge, I want to help in this documentation moving from contrib/ TBH it is my first contribution.
I can help moving documentation and improve it with detailed manifests examples

porridge · 2016-12-15T10:58:17Z

@mrmm as mentioned in #3 (comment) there are three main areas. Does any one of those feel particularly attractive to you?

bprashanth · 2016-12-15T23:59:10Z

Sorry I meant to comment sooner, I wrote some dev docs on how you can setup a local env, start with those: https://github.com/kubernetes/ingress/tree/master/docs/dev. Report if something doesn't work. Otherwise suggest picking one of the tasks in https://github.com/kubernetes/ingress/tree/master/examples, looking up the corresponding example from contrib/ (https://github.com/kubernetes/contrib/tree/master/ingress), getting it to work and writing the doc. Suggest following the pattern of other examples in main repo for formatting etc (https://github.com/kubernetes/kubernetes/tree/master/examples).

If there's no existing example in contrib, the feature is still possible but just undocumented (eg: nginx controller and sticky sessions), so you can try to figure out the right annotations and write the whole example.

mrmm · 2016-12-16T21:59:35Z

@porridge @bprashanth Thanks for your comments, I would like to help with writing detailed examples.

Add the Defaults for the new Structs

Support MultiClusterIngress API

…_1.2.0 Upgrade ingress 1.2.0

# This is the 1st commit message: Add feature flag to disable annotation prefix check in admission controller # This is the commit message kubernetes#2: Add log message for when ingress hits annotation check Indicates that the correct environment variable is set. Does not log on absence of environment variable. # This is the commit message kubernetes#3: Add flag for disabling legacy ingress class annotation prefix check # This is the commit message kubernetes#4: Remove negation from if statement on annotation prefix check # This is the commit message kubernetes#5: Add logline to indicate annotation prefix check is skipped

bprashanth added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 10, 2016

bprashanth mentioned this issue Nov 10, 2016

Port contrib/ingress #6

Closed

bprashanth assigned porridge Nov 28, 2016

This was referenced Dec 2, 2016

Developer documentation #40

Closed

Admin documentation #41

Closed

bowei closed this as completed Oct 11, 2017

diazjf referenced this issue in diazjf/ingress Aug 22, 2018

Merge pull request #3 from diazjf/crd-defaults

3272521

Add the Defaults for the new Structs

chiraggupta06 mentioned this issue Aug 7, 2019

Nginx ingress: Common name(IP) does not match in case of without host when trying to access nginx ingress path based service #4407

Closed

yizha mentioned this issue Dec 5, 2019

TCP Proxy Not Listening (tcp-services) #4213

Closed

riker09 mentioned this issue Mar 2, 2020

ssl-passthrough returning ingress cert #1947

Closed

haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021

Add more example and remvoe port_in_redirect flag (#3)

1753466

haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021

set cookie expiry (#3)

6c3af5b

daninthewoods mentioned this issue Apr 9, 2021

Nginx Ingress on Azure Kubernetes does not honor upstream-hash-by #7037

Closed

derek-burdick mentioned this issue Sep 25, 2021

Worker Segmentation Fault (v0.44.0) #6896

Closed

iamNoah1 mentioned this issue Dec 16, 2021

Disable default modsecurity_rules_file if modsecurity-snippet is specified #8021

Merged

9 tasks

XiShanYongYe-Chang pushed a commit to XiShanYongYe-Chang/ingress-nginx that referenced this issue Feb 25, 2022

Merge pull request kubernetes#3 from XiShanYongYe-Chang/support-mci

493a6ae

Support MultiClusterIngress API

Alvaro-Campesino added a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this issue Aug 5, 2022

Merge pull request kubernetes#3 from Alvaro-Campesino/upgrade_ingress…

1ac33b8

…_1.2.0 Upgrade ingress 1.2.0

DataMinded mentioned this issue Jun 2, 2023

Multiple CVE with 1.8.0 release #10026

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move issues and prs over from contrib/ingress #3

Move issues and prs over from contrib/ingress #3

bprashanth commented Nov 10, 2016

porridge commented Nov 25, 2016

bprashanth commented Nov 26, 2016

porridge commented Nov 28, 2016

aledbf commented Nov 29, 2016 •

edited

Loading

aledbf commented Nov 29, 2016 •

edited by thockin

Loading

porridge commented Nov 29, 2016 via email

aledbf commented Nov 29, 2016

bprashanth commented Nov 29, 2016

porridge commented Dec 2, 2016

porridge commented Dec 2, 2016

aledbf commented Dec 2, 2016

bprashanth commented Dec 2, 2016

bprashanth commented Dec 2, 2016

mrmm commented Dec 9, 2016 •

edited

Loading

porridge commented Dec 15, 2016

bprashanth commented Dec 15, 2016

mrmm commented Dec 16, 2016

Move issues and prs over from contrib/ingress #3

Move issues and prs over from contrib/ingress #3

Comments

bprashanth commented Nov 10, 2016

porridge commented Nov 25, 2016

bprashanth commented Nov 26, 2016

porridge commented Nov 28, 2016

aledbf commented Nov 29, 2016 • edited Loading

aledbf commented Nov 29, 2016 • edited by thockin Loading

porridge commented Nov 29, 2016 via email

aledbf commented Nov 29, 2016

bprashanth commented Nov 29, 2016

porridge commented Dec 2, 2016

porridge commented Dec 2, 2016

aledbf commented Dec 2, 2016

bprashanth commented Dec 2, 2016

bprashanth commented Dec 2, 2016

mrmm commented Dec 9, 2016 • edited Loading

porridge commented Dec 15, 2016

bprashanth commented Dec 15, 2016

mrmm commented Dec 16, 2016

aledbf commented Nov 29, 2016 •

edited

Loading

aledbf commented Nov 29, 2016 •

edited by thockin

Loading

mrmm commented Dec 9, 2016 •

edited

Loading