This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Detailed NGINX-Ingress-Controller status page config #2204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Thanks for the pr, can you please move it to https://github.com/kubernetes/ingress/tree/master/examples (in examples/status-page/nginx/, we would presumably add a example/status-page/{aws,gce..etc} as well, though I'm not sure it's worth it since it's pretty obvious how to visit the status page on a cloudprovider) |
|
@bprashanth alright! Already opened a new PR, please find it here kubernetes/ingress-nginx#84 |
|
[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
k8s-github-robot
added
the
needs-rebase
|
@ysolt PR needs rebase |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add detailed example for NGINX-Ingress-Controller status page configuration