Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmit checks #4

Closed
bprashanth opened this issue Nov 10, 2016 · 1 comment
Closed

Add presubmit checks #4

bprashanth opened this issue Nov 10, 2016 · 1 comment
Assignees
@aledbf
Labels
area/infra

Comments

@bprashanth
Copy link
Contributor

travis, lint, coverage and anything else we can leech off main or contrib repo. See checks that some other repos under kubernets/ have, eg: https://github.com/kubernetes/minikube or https://github.com/google/cadvisor. Assigning to Manuel since I think he already has something.
@bprashanth bprashanth mentioned this issue Nov 10, 2016
Closed
@aledbf aledbf mentioned this issue Nov 11, 2016
Closed
@aledbf
Copy link
Member

aledbf commented Feb 7, 2017

This is ready. Closing.

@aledbf aledbf closed this as completed Feb 7, 2017
@brezerk brezerk mentioned this issue Jul 18, 2018
Closed
@marianobilli marianobilli mentioned this issue Dec 16, 2020
Closed
haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021
@qiujian16
Add client-ca annotation (#4)
8a1a8ef 
* Add client-ca annotation

* Add build in template

* Fix client ca bug
haoqing0110 referenced this issue in stolostron/management-ingress Mar 5, 2021
@ckandag
Merge pull request #4 from open-cluster-management/secure-engg
802f5a6 
sonar onboarding
@derek-burdick derek-burdick mentioned this issue Sep 25, 2021
Closed
XiShanYongYe-Chang pushed a commit to XiShanYongYe-Chang/ingress-nginx that referenced this issue Feb 25, 2022
@karmada-bot
Merge pull request kubernetes#4 from XiShanYongYe-Chang/donot-run-e2e…
b1bfb8d 
…-chart

do not run kind-e2e-chart-tests first
Alvaro-Campesino pushed a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this issue Jan 16, 2023
@unai-ttxu
Improve CICD flow (kubernetes#4)
be6145e 
* Improve CICD flow

* Improve CICD flow
Alvaro-Campesino pushed a commit to Alvaro-Campesino/ingress-nginx-k8s that referenced this issue Jan 24, 2023
@unai-ttxu @Alvaro-Campesino
Improve CICD flow (kubernetes#4)
8ecc66a 
* Improve CICD flow

* Improve CICD flow
YngveMolnes pushed a commit to YngveMolnes/ingress-nginx that referenced this issue May 25, 2023
# This is a combination of 5 commits.
3eed9f3 
# This is the 1st commit message:

Add feature flag to disable annotation prefix check in admission controller

# This is the commit message kubernetes#2:

Add log message for when ingress hits annotation check

Indicates that the correct environment variable is set. Does not log on
absence of environment variable.

# This is the commit message kubernetes#3:

Add flag for disabling legacy ingress class annotation prefix check

# This is the commit message kubernetes#4:

Remove negation from if statement on annotation prefix check

# This is the commit message kubernetes#5:

Add logline to indicate annotation prefix check is skipped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aledbf aledbf

Labels
area/infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split implementations from generic code aledbf/ingress-nginx
2 participants
@aledbf @bprashanth