Ensure dep fix fsnotify #2392
Ensure dep fix fsnotify #2392
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 39.3% 39.35% +0.05%
==========================================
Files 73 73
Lines 5216 5216
==========================================
+ Hits 2050 2053 +3
+ Misses 2878 2876 -2
+ Partials 288 287 -1
Continue to review full report at Codecov.
|
| dep-ensure: | ||
| dep version || go get -u github.com/golang/dep/cmd/dep | ||
| dep ensure -v | ||
| dep prune -v |
There was a problem hiding this comment.
dep would do that implicitly if you added a [prune] section to Gopkg.toml:
[prune]
non-go = true
go-tests = true
unused-packages = trueThere was a problem hiding this comment.
Only if you have dep > 0.41
There was a problem hiding this comment.
I don't have a strong opinion about it, but I think maintainers can agree on using at least that version? (released on Jan 25)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
replaces #2389