Problem with fsnotify.v1 dependency

[dm3ch]

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.):

What keywords did you search in NGINX Ingress controller issues before filing this one? (If you have found any duplicates, you should instead reply there.):

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

NGINX Ingress controller version:
master

Kubernetes version (use kubectl version):
none

Environment:
Mac OS X high sierra

What happened:

When running dep ensure, getting

dep ensure                                                                            
Solving failure: No versions of gopkg.in/fsnotify.v1 met constraints:
	v1.4.2: unable to update checked out version: fatal: reference is not a tree: 629574ca2a5df945712d3079857300b5e4da0236
: command failed: [git checkout 629574ca2a5df945712d3079857300b5e4da0236]: exit status 12

When dep ensure --update

goroutine 1 [running]:
github.com/golang/dep/gps.(*solver).findValidVersion(0xc4203d7320, 0xc42241fea0, 0xc42039e9b0, 0x1, 0x1, 0x0, 0xc42039e9b0)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/gps/solver.go:927 +0x53f
github.com/golang/dep/gps.(*solver).createVersionQueue(0xc4203d7320, 0xc420202420, 0x14, 0x0, 0x0, 0xc42039e9b0, 0x1, 0x1, 0x0, 0x0, ...)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/gps/solver.go:914 +0x955
github.com/golang/dep/gps.(*solver).solve(0xc4203d7320, 0x17e7e40, 0xc420088010, 0x1, 0xc420593d10, 0xc420593d70)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/gps/solver.go:517 +0x5b0
github.com/golang/dep/gps.(*solver).Solve(0xc4203d7320, 0x17e7e40, 0xc420088010, 0x1843a90, 0xc4200140d0, 0xd, 0xc4202178c0)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/gps/solver.go:457 +0xe4
main.(*ensureCommand).runUpdate(0xc42016fe76, 0xc420095020, 0xc42007a1a0, 0x0, 0x0, 0xc420095080, 0x17eb320, 0xc420095740, 0xc4200140a4, 0x39, ...)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/cmd/dep/ensure.go:389 +0x2c0
main.(*ensureCommand).Run(0xc42016fe76, 0xc420095020, 0xc42007a1a0, 0x0, 0x0, 0x0, 0x0)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/cmd/dep/ensure.go:218 +0x838
main.(*Config).Run(0xc420094f00, 0xc420094f00)
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/cmd/dep/main.go:210 +0x11cb
main.main()
	/private/tmp/dep-20180127-38430-r7nlwc/src/github.com/golang/dep/cmd/dep/main.go:52 +0x1fc

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:
As I understand this . problem was caused by renaming gopkg.in/fsnotify.v1 package to gopkg.in/fsnotify/fsnotify.v1

[oilbeater]

maybe we should add a dep check in ci to make sure all dependency are valid and up to date

[aledbf]

maybe we should add a dep check in ci to make sure all dependency are valid and up to date

That is not required because the dependencies are in the vendor directory.

[andrewloux]

Have some context on this. I believe dep is likely searching for the source of that package in github.com/go-fsnotify/fsnotify instead of github.com/fsnotify/fsnotify (in particular flows); see: https://github.com/golang/dep/blob/338675da19c738092aea0be66bfaa591810feb56/gps/deduce.go#L281

@sbfaulkner put together a fix by making the repository name explicit wherever that package is referenced. I believe it's on the way :)

[sbfaulkner]

I'll submit a PR shortly... it's a two line change (and a big vendor folder update)

[aledbf]

Closing. Fixed in #2392