Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence unnecessary MissingAnnotations errors #2388

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Silence unnecessary MissingAnnotations errors #2388

merged 1 commit into from
Apr 20, 2018

Conversation

antoineco
Copy link
Contributor

Why we need this:

Silences the following error messages displayed on every call to store.updateSecretIngressMap() (unless these annotations are actually set):

E0420 16:06:35.692525   14631 store.go:722] Error reading secret reference in annotation "auth-secret": ingress rule without annotations
E0420 16:06:35.695298   14631 store.go:722] Error reading secret reference in annotation "auth-tls-secret": ingress rule without annotations

Continuity of #2382
See https://github.com/kubernetes/ingress-nginx/pull/2382/files#r183044272

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2018
@antoineco
Copy link
Contributor Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Apr 20, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Apr 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #2388 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
- Coverage   39.33%   39.31%   -0.02%     
==========================================
  Files          73       73              
  Lines        5214     5214              
==========================================
- Hits         2051     2050       -1     
- Misses       2874     2876       +2     
+ Partials      289      288       -1
Impacted Files Coverage Δ
internal/ingress/controller/store/store.go 54.08% <100%> (ø) ⬆️
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98cb5d...55facfa. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit c7b2d73 into kubernetes:master Apr 20, 2018
@antoineco antoineco deleted the silence-missingannotation branch April 20, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants