Accept ns/name Secret reference in annotations

[antoineco]

Fixes #2375

[antoineco]

/assign @aledbf

[aledbf]

/approve

[aledbf]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

@antoineco thanks!

[codecov-io]

Codecov Report

Merging #2382 into master will increase coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
+ Coverage   39.12%   39.33%   +0.21%     
==========================================
  Files          73       73              
  Lines        5204     5214      +10     
==========================================
+ Hits         2036     2051      +15     
+ Misses       2878     2874       -4     
+ Partials      290      289       -1

Impacted Files	Coverage Δ
internal/ingress/controller/store/store.go	54.08% <100%> (+2.46%)	⬆️
internal/ingress/controller/store/objectref.go	97.91% <0%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ff76a...9211f3b. Read the comment docs.

[antoineco]

Just realized parser.parseString() throws errors.ErrMissingAnnotations if the Ingress object being processed does not have a given annotation. This is probably something we want to silence.