Start Ingress cache Controller immediately

[antoineco]

What this PR does / why we need it:

Waiting 1 extra second before starting the cache Controller for Ingress objects seems unnecessary because the call to n.store.Run() is blocking until all caches are synced.

Special notes for your reviewer:

The change was originally introduced as part of #1891, but doesn't seem relevant anymore (unless I missed some evil detail).

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: antoineco
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: caseydavenport

Assign the PR to them by writing /assign @caseydavenport in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #2269 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2269      +/-   ##
==========================================
- Coverage   37.13%   37.12%   -0.02%     
==========================================
  Files          71       71              
  Lines        5025     5021       -4     
==========================================
- Hits         1866     1864       -2     
+ Misses       2874     2873       -1     
+ Partials      285      284       -1

Impacted Files	Coverage Δ
internal/ingress/controller/store/store.go	44.08% <100%> (-0.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc4dad...b42dcbe. Read the comment docs.

[antoineco]

/assign @aledbf

[aledbf]

(unless I missed some evil detail).

This 😄

As you know the controllers are independent (secrets, configmap, endpoints, services, ingress). The issue here is that the Ingress cache controller requires (in some cases) content from the others controllers (listers actually) like secrets. That is the reason why we cannot start the controllers on the same block. If you checked the linked issue in 1891 you will see one of the problems when we start at the same time (503 when an Ingress cannot fetch a secret)

[antoineco]

But at that stage we only populate caches don't we?

[aledbf]

But at that stage we only populate caches don't we?

We start the controllers and that will populate the local caches (listers)

[antoineco]

Clarified on Slack with @aledbf:

Please don't assume the initial sync contains everything, I've seen some cases where the informer starts receiving deltas after the initial sync.

My assumption was that the initial caches were always fully populated.