Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initial synchronization of ingress objects #1891

Merged
merged 1 commit into from
Jan 9, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 9, 2018

Which issue this PR fixes:

fixes #1890

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2018
@Stono
Copy link
Contributor

Stono commented Jan 9, 2018

Thank you so much for the swift fix @aledbf - once this PR is merged, how long does it take to get into the upstream?

@aledbf
Copy link
Member Author

aledbf commented Jan 9, 2018

@Stono this PR will be included in the next release https://github.com/kubernetes/ingress-nginx/projects/13
I think next week we will make a release

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 36.777% when pulling 85a7b97 on aledbf:wait-sync into 313fdd2 on kubernetes:master.

@aledbf aledbf merged commit 142b444 into kubernetes:master Jan 9, 2018
@aledbf aledbf deleted the wait-sync branch January 10, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress controller created AFTER basic auth enabled results in 503
5 participants