-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Add IngressClass aliases. #11109
Conversation
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/triage accepted |
@Gacko thanks for picking this up! I had not been able to get back to it due to some work issues so thanks for running with it and pushing it over the finish line! 🥂 |
Hey @slimm609! Nice to hear from you. I hope the way I pointed out the original work / idea was from you is fine with you! :) |
Absolutely, i just ran into a timing issues with the acquisition of VMware and the ability to contribute as well as some personal issues. I reviewed and think it fits the use cases with no concerns from me |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, rikatz, slimm609 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the possibility of defining IngressClass aliases which are identical copies of the original IngressClass but with an alias as name. This can be useful for development environments with only one Ingress Controller but production-like Ingress resources.
Thanks @slimm609 for the idea and initial work here!
I'm implementing it as the original PR got stale. Also this PR is based on two other PRs (#11104, #11108) and should only be merged after them.
Types of changes
How Has This Been Tested?
Added unit tests.
Checklist: